Re: Add support for tuple routing to foreign partitions

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Maksim Milyutin <milyutinma(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Add support for tuple routing to foreign partitions
Date: 2017-10-27 11:00:38
Message-ID: d11178ce-1164-e37f-89cf-4753ad1ceced@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2017/10/26 16:40, Etsuro Fujita wrote:
> Other changes I made
> to the executor are: (1) currently, we set the RT index for the root
> partitioned table to ri_RangeTableIndex of partitions' ResultRelInfos,
> but the proposed EXPLAIN requires that the partition's
> ri_RangeTableIndex is set to the RT index for that partition's RTE, to
> show that partition info in the output.  So, I made that change.

One thing I forgot to mention is: that would be also required to call
BeginForeignModify, ExecForeignInsert, and EndForeignModify with the
partition's ResultRelInfo.

I updated docs in doc/src/sgml/ddl.sgml the same way as [1]. (I used
only the ddl.sgml change proposed by [1], not all the changes.) I did
some cleanup as well. Please find attached an updated version of the patch.

Best regards,
Etsuro Fujita

[1]
https://www.postgresql.org/message-id/b19a8e2b-e000-f592-3e0b-3e90ba0fa816%40lab.ntt.co.jp

Attachment Content-Type Size
tuple-routing-to-foreign-partitions-v4.patch text/plain 61.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Chalke 2017-10-27 11:01:26 Re: Partition-wise aggregation/grouping
Previous Message Amit Kapila 2017-10-27 10:37:50 Re: Parallel safety for extern params