Re: Parallel safety for extern params

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel safety for extern params
Date: 2017-10-27 10:37:50
Message-ID: CAA4eK1JHZr8k83C4X08nuJGoohTMAuFhFZEU2G_yFrLD5WLi5Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 16, 2017 at 4:29 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Sat, Oct 14, 2017 at 1:51 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> I think the bug is in ExecGather(Merge): it assumes that if we're in
>> parallel mode, it's OK to start workers. But actually, it shouldn't
>> do this unless ExecutePlan ended up with use_parallel_mode == true,
>> which isn't quite the same thing. I think we might need ExecutePlan
>> to set a flag in the estate that ExecGather(Merge) can check.
>>
>
> Attached patch fixes the problem in a suggested way.
>
>

All the patches still apply and pass the regression test. I have
added this to CF to avoid losing the track of this patch.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2017-10-27 11:00:38 Re: Add support for tuple routing to foreign partitions
Previous Message Rajkumar Raghuwanshi 2017-10-27 10:29:13 Re: path toward faster partition pruning