Re: BUG #14759: insert into foreign data partitions fail

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Murat Tuncer <mtuncer(at)gmail(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #14759: insert into foreign data partitions fail
Date: 2017-08-01 01:18:27
Message-ID: b19a8e2b-e000-f592-3e0b-3e90ba0fa816@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2017/08/01 10:10, David G. Johnston wrote:
> On Mon, Jul 31, 2017 at 5:42 PM, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp
>> wrote:
>
>>
>> On a second thought though, I think we should list the foreign table
>> partitions' limitations in only one place, that is, the CREATE FOREIGN
>> TABLE reference page. Listing them under 5.10.2.3. seems a bit off to me,
>> because other limitations listed there are those of the new partitioned
>> table objects, such as lack of global index constraints, etc. Lack of
>> tuple-routing to foreign partitions does not seem to me of the similar
>> nature. Also, the same text is no longer repeated in 3 different places.
>>
>> Thoughts on the updated patch?
>>
>
> Overall, works for me.
>
> grammar (add a couple of commas for flow) and style (dropping the first
> "the")
>
> current: "(both the user-defined constraints such as <literal>CHECK</> or
> <literal>NOT NULL</> clauses and the partition constraint)"
> proposed: "(both user-defined constraints, such as <literal>CHECK</> or
> <literal>NOT NULL</> clauses, and the partition constraint)"

Good points; fixed in the updated patch.

Thanks,
Amit

Attachment Content-Type Size
0001-Clarify-that-partition-constraint-is-not-enforced-on-v4.patch text/plain 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-08-01 01:47:57 Re: Constraint exclusion for partitioned tables
Previous Message Andres Freund 2017-08-01 01:14:07 Re: BUG #14758: Segfault with logical replication on a function index

Browse pgsql-bugs by date

  From Date Subject
Next Message Etsuro Fujita 2017-08-01 03:45:26 Re: [HACKERS] BUG #14759: insert into foreign data partitions fail
Previous Message Andres Freund 2017-08-01 01:14:07 Re: BUG #14758: Segfault with logical replication on a function index