| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions |
| Date: | 2023-01-12 07:34:25 |
| Message-ID: | cc1d70ab-3304-1d2c-9976-0b8cd9ce5fee@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.01.23 08:21, Peter Eisentraut wrote:
> On 23.11.22 14:57, Aleksander Alekseev wrote:
>> Hi Andres,
>>
>> Thanks for the review!
>>
>>> I don't think it is correct for any of these to add const. The only
>>> reason it
>>> works is because of casting etc.
>>
>> Fair enough. PFA the corrected patch v2.
>
> This patch version looks correct to me. It is almost the same as the
> one that Andres had posted in his thread, except that yours also
> modifies slist_delete() and dlist_member_check(). Both of these changes
> also look correct to me.
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-01-12 07:35:43 | Re: Using WaitEventSet in the postmaster |
| Previous Message | Drouvot, Bertrand | 2023-01-12 07:09:03 | Re: Strengthen pg_waldump's --save-fullpage tests |