Re: Strengthen pg_waldump's --save-fullpage tests

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Strengthen pg_waldump's --save-fullpage tests
Date: 2023-01-12 07:09:03
Message-ID: 53e4d5c3-ee4f-27bb-44eb-31d7e4206e29@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 1/12/23 5:44 AM, Michael Paquier wrote:
> On Wed, Jan 11, 2023 at 07:17:47PM +0530, Bharath Rupireddy wrote:
>> Note that the raw page on the table might differ not just in page LSN
>> but also in other fields, for instance see heap_mask for instance. It
>> masks lsn, checksum, hint bits, unused space etc. before verifying FPI
>> consistency during recovery in
>> verifyBackupPageConsistency().
>
> FWIW, I don't really want to enter in this business here. That feels
> like a good addition of technical debt compared to the potential
> gain.

Agree, let's forget about it.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-01-12 07:34:25 Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions
Previous Message shiy.fnst@fujitsu.com 2023-01-12 07:03:38 RE: Fix pg_publication_tables to exclude generated columns