| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions |
| Date: | 2023-01-18 18:22:14 |
| Message-ID: | 20230118182214.co7dp4oahiunwg57@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-01-12 08:34:25 +0100, Peter Eisentraut wrote:
> On 07.01.23 08:21, Peter Eisentraut wrote:
> > On 23.11.22 14:57, Aleksander Alekseev wrote:
> > > Hi Andres,
> > >
> > > Thanks for the review!
> > >
> > > > I don't think it is correct for any of these to add const. The
> > > > only reason it
> > > > works is because of casting etc.
> > >
> > > Fair enough. PFA the corrected patch v2.
> >
> > This patch version looks correct to me. It is almost the same as the
> > one that Andres had posted in his thread, except that yours also
> > modifies slist_delete() and dlist_member_check(). Both of these changes
> > also look correct to me.
>
> committed
Unfortunately this causes a build failure with ILIST_DEBUG
enabled. dlist_member_check() uses dlist_foreach(), which isn't set up to work
with const :(. I'll push a quick workaround.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2023-01-18 18:26:48 | Re: [PATCH] Add <<none>> support to sepgsql_restorecon |
| Previous Message | Bruce Momjian | 2023-01-18 18:11:12 | Re: document the need to analyze partitioned tables |