| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions |
| Date: | 2023-01-07 07:21:26 |
| Message-ID: | 8935187f-0312-afd6-142a-f48142178dcb@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23.11.22 14:57, Aleksander Alekseev wrote:
> Hi Andres,
>
> Thanks for the review!
>
>> I don't think it is correct for any of these to add const. The only reason it
>> works is because of casting etc.
>
> Fair enough. PFA the corrected patch v2.
This patch version looks correct to me. It is almost the same as the
one that Andres had posted in his thread, except that yours also
modifies slist_delete() and dlist_member_check(). Both of these changes
also look correct to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2023-01-07 08:55:31 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Pavel Stehule | 2023-01-07 07:09:27 | Re: Schema variables - new implementation for Postgres 15 (typo) |