Re: Add wait events for server logging destination writes

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: 신성준 <shinsj4653(at)gmail(dot)com>
Cc: Nikolay Samokhvalov <nik(at)postgres(dot)ai>, assam258(at)gmail(dot)com, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, x4mmm(at)yandex-team(dot)ru, wolakk(at)gmail(dot)com, andreas(at)proxel(dot)se, jakub(dot)wartak(at)enterprisedb(dot)com, horikyota(dot)ntt(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com
Subject: Re: Add wait events for server logging destination writes
Date: 2026-11-13 06:09:03
Message-ID: avapfgHpJjfaVMTz@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 13, 2026 at 12:23:52AM +0900, 신성준 wrote:
> Done. 0001 adds pgstat_report_wait_swap(), 0002 uses it for the
> logging writes, and 0003 does the same for the Windows-only paths.

Thanks. I'm wondering if others feel that this idea feels like a
hack, though, because it's just a workaround due to the fact that wait
events are not handled in a nested way. It's not clear to me if folks
would prefer that and if catalogs should be upgraded to reflect that,
so perhaps it would not be a bad thing to wait for more opinions.

Note that I am not convinced about adding the whole set of suggested
wait events just based on the reason that they seem useful. For one,
I am not able to check the Windows-specific ones and if they actually
make sense on their own.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenhui qiu 2026-11-13 06:13:07 Re: Wrong results from GROUP BY column removal
Previous Message Keyerror Smart 2026-11-13 05:53:32 Re: [PATCH] Consider window functions when reordering GROUP BY items