| From: | 신성준 <shinsj4653(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nikolay Samokhvalov <nik(at)postgres(dot)ai>, assam258(at)gmail(dot)com, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, x4mmm(at)yandex-team(dot)ru, wolakk(at)gmail(dot)com, andreas(at)proxel(dot)se, jakub(dot)wartak(at)enterprisedb(dot)com, horikyota(dot)ntt(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com |
| Subject: | Re: Add wait events for server logging destination writes |
| Date: | 2026-11-12 15:23:52 |
| Message-ID: | CACdN0M4r7XbHbL5usP0_8EQ7RNWHXm55QLXYmZwr0PODbcwseQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Michael, thanks for the review.
> I am wondering if something like a pgstat_report_wait_swap() would be
> more adapted?
That's simpler, thanks. Done in v10.
> This is AI slop to me. None of this level of details is required.
Agreed, removed. The commit messages are much shorter as well.
And point taken on the agent. I'll check more carefully what goes
out from now on.
> Also, perhaps split your new API into a first patch, then write a
> second patch that makes use of it.
Done. 0001 adds pgstat_report_wait_swap(), 0002 uses it for the
logging writes, and 0003 does the same for the Windows-only paths.
Rebased on b0496e30830.
--
Seongjun
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0002-Add-wait-events-for-server-logging-destination-w.patch | application/octet-stream | 5.9 KB |
| v10-0001-Add-pgstat_report_wait_swap.patch | application/octet-stream | 2.3 KB |
| v10-0003-Add-wait-events-for-Windows-specific-logging-out.patch | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-11-12 15:40:24 | Re: reconsider_full_join_clause fails to consider if COALESCE() arguments are NULL-preserving |
| Previous Message | Kirill Reshke | 2026-11-12 15:18:08 | Re: reconsider_full_join_clause fails to consider if COALESCE() arguments are NULL-preserving |