| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | 신성준 <shinsj4653(at)gmail(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, assam258(at)gmail(dot)com, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kirk Wolak <wolakk(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: Add wait events for server logging destination writes |
| Date: | 2026-11-13 07:10:39 |
| Message-ID: | B784BF7C-08D5-4C73-8C9F-3FC671C91F66@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
On 13 Nov 2026, Michael Paquier wrote:
> it's just a workaround due to the fact that wait
> events are not handled in a nested way.
I support moving towards nested waits. Keeping the previous event in
the caller's frame is the approach I had in mind. Starting with the
logging sites seems a useful step.
The patch addresses the case that concerns me: logs on a slow boot disk
not showed up in stats.
For follow-up, I'd look at WaitEventSetWait() and FileReadV(). Both
still clear an outer event when their wait ends.
Could we reuse the debug nesting check to collect inner/outer call
sites over a check-world run and identify most useful sites that can
be converted to nested?
Thank you!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-11-13 07:24:48 | Re: [DEPARSE] Operators on ROW() constructors read back as row comparisons |
| Previous Message | Zsolt Parragi | 2026-11-13 07:08:06 | Re: [BUG / PATCH] PG19: VACUUM misestimates reltuples (often 0) after on-access VM setting |