Re: Wrong results from GROUP BY column removal

From: wenhui qiu <qiuwenhuifx(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong results from GROUP BY column removal
Date: 2026-11-13 06:13:07
Message-ID: CAGjGUA+ihzY9SHqWwm_nHpMPXK+XS9TrMrFfuG21M0LYYeSAYw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Richard

>
> > I disagree. This function doesn't free any of its other bitmapsets,
> > so I'm not sure where you get that conclusion. Freeing just this one
> > would look odd. Also, I don't see the point: this one small bitmapset
> > has no real impact on memory usage, and it will be cleaned up along
> > with the planner's memory context anyway.
>
> Sorry for the noise — I misremembered how remove_useless_groupby_columns()
> handles its bitmapsets. You're right, there's no need to free
> nullable_relids here.
>
>
Thanks

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Michael Paquier 2026-11-13 06:09:03 Re: Add wait events for server logging destination writes