Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows

On 2026-09-27 Su 11:34 PM, Michael Paquier wrote:
> On Fri, Sep 25, 2026 at 12:11:19PM +0300, Nazir Bilal Yavuz wrote:
>> I haven't looked at the patches yet but +1 to fixing these problems.
>>
>> I saw same problems on the macOS [1] and MinGW CI [2] task when we
>> were using Cirrus. These discussions might help.
> Looking at the patch, I cannot get on board with the idea that anybody
> adding a test would need to add a new ipc_run_text_mode() call to make
> sure that the redirection is able to work correctly. Couldn't there
> be a more central solution so as we limit the footprint of this logic
> in some way? This kind of solution is just going to create noise in
> the long-term, especially when it comes to the buildfarm (aka I doubt
> that we should spend cycles remembering that this is required)..

I think the right way is to have a wrapper function as in the attached,
so instead of calling IPC::Run::run you would call ipc_run ...

Note that this patch only touches the sites that will actually be
affected by this. If we wanted to be consistent we would replace calls
in a further 23 files.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com