| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Andrew Bille <andrewbille(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows |
| Date: | 2026-09-28 03:34:16 |
| Message-ID: | arngOKBaE4x19Y7_@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 25, 2026 at 12:11:19PM +0300, Nazir Bilal Yavuz wrote:
> I haven't looked at the patches yet but +1 to fixing these problems.
>
> I saw same problems on the macOS [1] and MinGW CI [2] task when we
> were using Cirrus. These discussions might help.
Looking at the patch, I cannot get on board with the idea that anybody
adding a test would need to add a new ipc_run_text_mode() call to make
sure that the redirection is able to work correctly. Couldn't there
be a more central solution so as we limit the footprint of this logic
in some way? This kind of solution is just going to create noise in
the long-term, especially when it comes to the buildfarm (aka I doubt
that we should spend cycles remembering that this is required)..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-28 03:38:05 | Re: Translation of the NextOID message in pg_controldata |
| Previous Message | Dilip Kumar | 2026-09-28 03:32:03 | Re: Proposal: Conflict log history table for Logical Replication |