| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andrew Bille <andrewbille(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows |
| Date: | 2026-09-28 23:24:24 |
| Message-ID: | arr3KGsx0z7xhN-8@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 28, 2026 at 12:54:18PM -0400, Andrew Dunstan wrote:
> I think the right way is to have a wrapper function as in the attached, so
> instead of calling IPC::Run::run you would call ipc_run ...
>
> Note that this patch only touches the sites that will actually be affected
> by this. If we wanted to be consistent we would replace calls in a further
> 23 files.
That seems much better in the long-run, thanks. The
ipc_run_text_mode() being published in Utils.pm does not seem
necessary, though. This is a part that I'm sure could become
confusing if we allow code outside of Utils.pm to use it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-09-28 23:29:25 | Re: Parallel autovacuum: leader crashes when no DSM segment can be created |
| Previous Message | Fabrízio Mello | 2026-09-28 23:20:56 | Add pg_stat_log_messages: cumulative statistics about server log messages (was: Add contrib module pg_stat_log: cumulative statistics about server log messages) |