| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Aditya Kamath <Aditya(dot)Kamath1(at)ibm(dot)com>, Srirama Kucherlapati <sriram(dot)rk(at)in(dot)ibm(dot)com>, "peter(at)eisentraut(dot)org" <peter(at)eisentraut(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "tristan(at)partin(dot)io" <tristan(at)partin(dot)io>, "postgres-ibm-aix(at)wwpdl(dot)vnet(dot)ibm(dot)com" <postgres-ibm-aix(at)wwpdl(dot)vnet(dot)ibm(dot)com> |
| Subject: | Re: AIX support |
| Date: | 2026-01-30 04:38:42 |
| Message-ID: | aXw10nRRVYLyrfXM@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 29, 2026 at 06:48:37PM -0500, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> Should any of these be backpatched, actually? Based on the lack of
>> complaints, it does not seem so to me, but if we are targetting a
>> backpatch of the AIX port, that would be required.
>
> There's no plan to backpatch the AIX port ... but if we can clean
> up this include-path mess not too invasively, I think it might be
> a good idea to back-patch that much. I'm concerned that confusion
> between <float.h> and utils/float.h might be a problem on other
> platforms too.
Noted. Attached is the patch I am finishing with, tested with meson
and configure/make with and without VPATH.
While looking at the whole object dependency tree in the builds, I
have settled down to a reuse of the same logic as guc_tables.inc.c for
configure/make, by pushing down one level the generation of the three
wait event files. These are not anymore saved in
src/backend/utils/activity/, just src/backend/utils/, including them
under header-stamp. Building directly in src/backend/utils/activity/
also works, with two rules in src/backend/utils/activity/Makefile to
force a rebuild. The files are then included as if they were in
include/utils/, with the generation of links from src/backend/utils/
to src/include/utils/, just like guc_tables.inc.c. That's the least
invasive method I could come up with.
I have run out of tokens for the CI this month, so I have not been
able to check it there. My manual tests across all three build
methods are working.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-incorrect-generation-of-wait-event-files.patch | text/x-diff | 9.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2026-01-30 04:49:55 | Re: [Proposal] Adding Log File Capability to pg_createsubscriber |
| Previous Message | Amit Kapila | 2026-01-30 04:31:38 | Re: pg_upgrade: optimize replication slot caught-up check |