| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Aditya Kamath <Aditya(dot)Kamath1(at)ibm(dot)com>, Srirama Kucherlapati <sriram(dot)rk(at)in(dot)ibm(dot)com>, "peter(at)eisentraut(dot)org" <peter(at)eisentraut(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "tristan(at)partin(dot)io" <tristan(at)partin(dot)io>, "postgres-ibm-aix(at)wwpdl(dot)vnet(dot)ibm(dot)com" <postgres-ibm-aix(at)wwpdl(dot)vnet(dot)ibm(dot)com> |
| Subject: | Re: AIX support |
| Date: | 2026-01-30 05:06:08 |
| Message-ID: | aXw8QDOu2OxPpeTH@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 30, 2026 at 01:38:42PM +0900, Michael Paquier wrote:
> While looking at the whole object dependency tree in the builds, I
> have settled down to a reuse of the same logic as guc_tables.inc.c for
> configure/make, by pushing down one level the generation of the three
> wait event files. These are not anymore saved in
> src/backend/utils/activity/, just src/backend/utils/, including them
> under header-stamp. Building directly in src/backend/utils/activity/
> also works, with two rules in src/backend/utils/activity/Makefile to
> force a rebuild. The files are then included as if they were in
> include/utils/, with the generation of links from src/backend/utils/
> to src/include/utils/, just like guc_tables.inc.c. That's the least
> invasive method I could come up with.
>
> I have run out of tokens for the CI this month, so I have not been
> able to check it there. My manual tests across all three build
> methods are working.
Scratch that a bit.. Some grepping is pointing out that
generated_sources_ac would become incorrect in
src/include/utils/meson.build.
Three paths in wait_event_names.txt were also inconsistent. It is
worth noting that the sgml path is entirely wrong, this is generated
in doc/src/sgml/.
Comments and thoughts are welcome.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-incorrect-generation-of-wait-event-files.patch | text/x-diff | 10.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2026-01-30 05:08:49 | Add expressions to pg_restore_extended_stats() |
| Previous Message | VASUKI M | 2026-01-30 04:59:03 | Re: Optional skipping of unchanged relations during ANALYZE? |