Re: [Proposal] Adding Log File Capability to pg_createsubscriber

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date: 2026-01-30 04:49:55
Message-ID: CALDaNm3Kx=qv2XOf9x-bsOQx8R2aRBuJKxeTU0+SKR70G9WjZA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 26 Jan 2026 at 07:08, Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> wrote:
>
> Thank you, I have made the changes and attached the patch.

Currently the files are created like this with the v3 patch:
If -l logdir is specified:
logdir
├── pg_createsubscriber_internal_2026-01-30-10-00-58.300264.log
├── pg_createsubscriber_server_2026-01-30-10-00-58.300264.log
├── pg_createsubscriber_internal_2026-01-30-10-08-54.270230.log
└── pg_createsubscriber_server_2026-01-30-10-08-54.270230.log

You might have slightly misunderstood my previous comment, but the
expected is like:
logdir
├── 20260130T100618.912
│ ├── pg_createsubscriber_internal.log
│ └── pg_createsubscriber_server.log
└── 20260130T101320.952
├── pg_createsubscriber_internal.log
└── pg_createsubscriber_server.log

Let's keep the similar structure as created by pg_upgrade. You can
execute pg_upgrade once see how it is created. You can refer to
make_outputdirs for the same.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message VASUKI M 2026-01-30 04:59:03 Re: Optional skipping of unchanged relations during ANALYZE?
Previous Message Michael Paquier 2026-01-30 04:38:42 Re: AIX support