Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Christoph Berg <myon(at)debian(dot)org>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: 2023-03-09 00:30:15
Message-ID: ZAkol+4UyWuBR7PS@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Mar 09, 2023 at 12:39:08AM +0100, Tomas Vondra wrote:
> IMO we should fix that. We have a bunch of buildfarm members running on
> Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP
> tests. But considering how trivial the fix is ...
>
> Barring objections, I'll push a fix early next week.

+1, better to change that, thanks. Actually, would --rm be OK even on
Windows? As far as I can see, the CI detects a LZ4 command for the
VS2019 environment but not the liblz4 libraries that would be needed
to trigger the set of tests.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-03-09 01:58:08 pgsql: meson: tests: Adjust with_icu/ZSTD env vars for pg_dump, pg_base
Previous Message Michael Paquier 2023-03-09 00:22:19 pgsql: doc: Add guidelines to generate coverage reports with meson

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-03-09 00:34:38 Re: Track IO times in pg_stat_io
Previous Message Nathan Bossart 2023-03-09 00:30:02 Re: Add error functions: erf() and erfc()