| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add error functions: erf() and erfc() |
| Date: | 2023-03-09 00:30:02 |
| Message-ID: | 20230309003002.GA3623552@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 09, 2023 at 12:27:47AM +0000, Dean Rasheed wrote:
> On Thu, 9 Mar 2023 at 00:13, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> I'm also wondering about whether we need the isinf() checks. IIUC that
>> should never happen, but maybe you added that "just in case."
>
> I copied those from dtanh(), otherwise I probably wouldn't have
> bothered. erf() is always in the range [-1, 1], just like tanh(), so
> it should never overflow, but maybe it can happen in a broken
> implementation.
Okay. This looks good to me, then.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-03-09 00:30:15 | Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) |
| Previous Message | Dean Rasheed | 2023-03-09 00:27:47 | Re: Add error functions: erf() and erfc() |