| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Christoph Berg <myon(at)debian(dot)org>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) |
| Date: | 2023-03-09 18:00:35 |
| Message-ID: | 0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3/9/23 01:30, Michael Paquier wrote:
> On Thu, Mar 09, 2023 at 12:39:08AM +0100, Tomas Vondra wrote:
>> IMO we should fix that. We have a bunch of buildfarm members running on
>> Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP
>> tests. But considering how trivial the fix is ...
>>
>> Barring objections, I'll push a fix early next week.
>
> +1, better to change that, thanks. Actually, would --rm be OK even on
> Windows? As far as I can see, the CI detects a LZ4 command for the
> VS2019 environment but not the liblz4 libraries that would be needed
> to trigger the set of tests.
Thanks for noticing that. I'll investigate next week.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-03-09 18:40:30 | pgsql: Fix 9637badd9f. |
| Previous Message | Jeff Davis | 2023-03-09 17:35:35 | Re: pgsql: pg_upgrade: copy locale and encoding information to new cluster. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-03-09 18:36:47 | Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences |
| Previous Message | Nathan Bossart | 2023-03-09 17:58:46 | Re: improving user.c error messages |