Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Christoph Berg <myon(at)debian(dot)org>
Cc: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: 2023-03-08 23:39:08
Message-ID: 819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 3/8/23 20:20, Daniel Gustafsson wrote:
>> On 8 Mar 2023, at 18:55, Christoph Berg <myon(at)debian(dot)org> wrote:
>
>> 18.04 will be EOL in a few weeks so it might be ok to just say it's
>> not supported, but removing the input file manually after calling lz4
>> would be an easy fix.
>
> Is it reasonable to expect that this version of LZ4 can/will appear on any
> other platform outside of archeology? Removing the file manually would be a
> trivial way to stabilize but if it's only expected to happen on platforms which
> are long since EOL by the time 16 ships then the added complication could be
> hard to justify.
>

IMO we should fix that. We have a bunch of buildfarm members running on
Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP
tests. But considering how trivial the fix is ...

Barring objections, I'll push a fix early next week.

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-03-09 00:22:19 pgsql: doc: Add guidelines to generate coverage reports with meson
Previous Message Andrew Dunstan 2023-03-08 22:13:00 Re: pgsql: 001_libpq_pipeline.pl: use Test::Differences if available

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-03-09 00:13:13 Re: Add error functions: erf() and erfc()
Previous Message Dean Rasheed 2023-03-08 23:29:12 Re: Add error functions: erf() and erfc()