| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE |
| Date: | 2022-09-06 06:27:58 |
| Message-ID: | YxbobofjLkY8r+EQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> I think renumbering this makes sense. We could just leave the comment
>> as is if we don't come up with a better wording.
>
> +1, I see no need to change the comment. We just need to establish
> the precedent that values within the GUC_UNIT_MEMORY field can be
> chosen sequentially.
+1.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-09-06 06:40:07 | pgsql: Add psql tab compression for SET COMPRESSION with ALTER TABLE |
| Previous Message | Tom Lane | 2022-09-06 05:57:53 | Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2022-09-06 06:30:00 | Re: Proposal to provide the facility to set binary format output for specific OID's per session |
| Previous Message | Ibrar Ahmed | 2022-09-06 06:25:05 | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row |