| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE |
| Date: | 2022-09-07 09:11:37 |
| Message-ID: | 316575e0-64b8-3db6-865c-165b94958ce0@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 06.09.22 08:27, Michael Paquier wrote:
> On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote:
>> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>>> I think renumbering this makes sense. We could just leave the comment
>>> as is if we don't come up with a better wording.
>>
>> +1, I see no need to change the comment. We just need to establish
>> the precedent that values within the GUC_UNIT_MEMORY field can be
>> chosen sequentially.
>
> +1.
committed without the comment change
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2022-09-07 09:15:08 | Re: [postgis-devel] PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features) |
| Previous Message | Peter Eisentraut | 2022-09-07 09:11:11 | pgsql: Renumber confusing value for GUC_UNIT_BYTE |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2022-09-07 09:15:08 | Re: [postgis-devel] PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features) |
| Previous Message | Drouvot, Bertrand | 2022-09-07 09:11:11 | Re: Patch to address creation of PgStat* contexts with null parent context |