| From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
|---|---|
| To: | Hamid Akhtar <hamid(dot)akhtar(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row |
| Date: | 2022-09-06 06:25:05 |
| Message-ID: | CALtqXTeX8H=gGvgJy16E0aWLSk1xwiBQ7OLELFtZ_ujGpHLNEw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 1, 2022 at 11:29 PM Naeem Akhter <naeem(dot)akhter(at)percona(dot)com>
wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
>
> Looks good to me.
>
> The new status of this patch is: Ready for Committer
>
The patch has a compilation error on the latest code base, please rebase
your patch.
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:27: error:
‘result’ was not declared in this scope
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
[03:08:46.087] | ^~~~~~
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:40: error:
expected primary-expression before ‘scanbuflen’
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
...
--
Ibrar Ahmed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-09-06 06:27:58 | Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE |
| Previous Message | Ibrar Ahmed | 2022-09-06 06:18:35 | Re: Compilation issue on Solaris. |