From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
---|---|
To: | Dave Cramer <davecramer(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Sehrope Sarkuni <sehrope(at)jackdb(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Jack Christensen <jack(at)jackchristensen(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Subject: | Re: Proposal to provide the facility to set binary format output for specific OID's per session |
Date: | 2022-09-06 06:30:00 |
Message-ID: | CALtqXTfpXVBb6A+z0meeeCSNPC_2RFq_q8_CnXWAJS_=gxe5sA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Aug 12, 2022 at 5:48 PM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>
>
> On Fri, 5 Aug 2022 at 17:51, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
>> On Tue, Jul 26, 2022 at 08:11:04AM -0400, Dave Cramer wrote:
>> > Attached patch to correct these deficiencies.
>>
>> You sent a patch to be applied on top of the first patch, but cfbot
>> doesn't
>> know that, so it says the patch doesn't apply.
>> http://cfbot.cputube.org/dave-cramer.html
>>
>> BTW, a previous discussion about this idea is here:
>>
>> https://www.postgresql.org/message-id/flat/40cbb35d-774f-23ed-3079-03f938aacdae(at)2ndquadrant(dot)com
>
>
> squashed patch attached
>
> Dave
>
The patch does not apply successfully; a rebase is required.
=== applying patch ./0001-add-format_binary.patch
patching file src/backend/tcop/postgres.c
Hunk #1 succeeded at 97 (offset -8 lines).
patching file src/backend/tcop/pquery.c
patching file src/backend/utils/init/globals.c
patching file src/backend/utils/misc/guc.c
Hunk #1 succeeded at 144 (offset 1 line).
Hunk #2 succeeded at 244 with fuzz 2 (offset 1 line).
Hunk #3 succeeded at 4298 (offset -1 lines).
Hunk #4 FAILED at 12906.
1 out of 4 hunks FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/include/miscadmin.h
--
Ibrar Ahmed
From | Date | Subject | |
---|---|---|---|
Next Message | Ibrar Ahmed | 2022-09-06 06:32:18 | Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc? |
Previous Message | Michael Paquier | 2022-09-06 06:27:58 | Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE |