Re: pgsql: Add suport for server-side LZ4 base backup compression.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date: 2022-02-12 04:38:45
Message-ID: Ygc51WVAFGocSu4h@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Feb 11, 2022 at 01:54:36PM +0000, Robert Haas wrote:
> Add suport for server-side LZ4 base backup compression.
>
> LZ4 compression can be a lot faster than gzip compression, so users
> may prefer it even if the compression ratio is not as good. We will
> want pg_basebackup to support LZ4 compression and decompression on the
> client side as well, and there is a pending patch for that, but it's
> by a different author, so I am committing this part separately for
> that reason.
>
> Jeevan Ladhe, reviewed by Tushar Ahuja and by me.

copperhead seems to be unhappy here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=copperhead&dt=2022-02-11%2021%3A52%3A48
# Running: lz4 -d -m
/home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/base.tar.lz4
Can't exec "lz4": No such file or directory at
/home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/../../../src/test/perl/PostgreSQL/Test/Utils.pm
line 388.
Bail out! failed to execute command "lz4 -d -m
/home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/base.tar.lz4":
No such file or directory
### Stopping node "primary" using mode immediate

Perhaps you'd better check that 'decompress_program' can be executed
and skip things if the command is not around? Note that
020_pg_receivewal.pl does an extra lz4 --version as a safety measure,
but 008_untar.pl does not.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Christoph Berg 2022-02-12 08:49:18 Re: pgsql: Add TAP test to automate the equivalent of check_guc
Previous Message Michael Paquier 2022-02-12 04:29:54 Re: pgsql: Add TAP test to automate the equivalent of check_guc

Browse pgsql-hackers by date

  From Date Subject
Next Message Shinoda, Noriyoshi (PN Japan FSIP) 2022-02-12 06:01:15 RE: refactoring basebackup.c
Previous Message Peter Geoghegan 2022-02-12 04:30:30 Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations