| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Date: | 2022-02-12 12:24:46 |
| Message-ID: | CA+TgmoZWEjAPK3SHxGzvEPF9CAPTLUMvkZvU_jou8sNUx_gRNA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Feb 11, 2022 at 11:39 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Perhaps you'd better check that 'decompress_program' can be executed
> and skip things if the command is not around? Note that
> 020_pg_receivewal.pl does an extra lz4 --version as a safety measure,
> but 008_untar.pl does not.
You may be right, but I'm not entirely convinced. $ENV{'LZ4'} here is
being set by make, and make is setting it to whatever configure found.
If configure found a version of the lz4 program that doesn't actually
work, isn't that configure's fault, or the system administrator's
fault, rather than this test's fault?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-02-12 16:23:23 | Re: pgsql: Add TAP test to automate the equivalent of check_guc |
| Previous Message | Christoph Berg | 2022-02-12 08:49:18 | Re: pgsql: Add TAP test to automate the equivalent of check_guc |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-02-12 13:25:58 | Re: Race condition in TransactionIdIsInProgress |
| Previous Message | Bharath Rupireddy | 2022-02-12 11:33:08 | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |