RE: refactoring basebackup.c

Hi, Hackers.
Thank you for developing a great feature.
The current help message shown below does not seem to be able to specify the 'client-' or 'server-' for lz4 compression.
--compress = {[{client, server}-]gzip, lz4, none}[:LEVEL]

The attached small patch fixes the help message as follows:
--compress = {[{client, server}-]{gzip, lz4}, none}[:LEVEL]

Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Robert Haas <robertmhaas(at)gmail(dot)com>
Sent: Saturday, February 12, 2022 12:50 AM
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com>; Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>; Abhijit Menon-Sen <ams(at)toroid(dot)org>; Dmitry Dolgov <9erthalion6(at)gmail(dot)com>; Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>; Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>; pgsql-hackers(at)postgresql(dot)org; tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Subject: Re: refactoring basebackup.c

On Fri, Feb 11, 2022 at 10:29 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> FYI: there's a couple typos in the last 2 patches.

Hmm. OK. But I don't consider "can be optionally specified" incorrect or worse than "can optionally be specified".

I do agree that spelling words correctly is a good idea.

--
Robert Haas
EDB: http://www.enterprisedb.com