| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Date: | 2022-02-12 22:06:43 |
| Message-ID: | 20220212220643.ozuvq2k4cjkcnr2v@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2022-02-12 13:38:45 +0900, Michael Paquier wrote:
> Perhaps you'd better check that 'decompress_program' can be executed
> and skip things if the command is not around? Note that
> 020_pg_receivewal.pl does an extra lz4 --version as a safety measure,
> but 008_untar.pl does not.
Actually executing the command doesn't seem useful? It doesn't seem useful to
ignore an executable that's not actually executable or such. Testing whether
the file exists makes sense though.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-12 22:09:13 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Previous Message | Andres Freund | 2022-02-12 22:04:13 | Re: pgsql: Add decoding of sequences to test_decoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-12 22:09:13 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Previous Message | Justin Pryzby | 2022-02-12 22:06:40 | Re: Adding CI to our tree |