From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
---|---|
To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Obsolete comments in ResultRelInfo struct |
Date: | 2025-08-12 10:21:55 |
Message-ID: | CAPmGK140581qQRWA97rb+mW7orTBJ+DMgw5rzS=qgdSCkoX6XA@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Tue, Aug 12, 2025 at 2:03 AM Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> On Mon, 11 Aug 2025 at 12:25, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> >
> > /*
> > * Other information needed by child result relations
> > *
> > * RootResultRelInfo gives the target relation mentioned in the query.
> > * Used as the root for tuple routing and/or transition capture.
> > *
> > * PartitionTupleSlot is non-NULL if the relation is a partition to route
> > * tuples into and RootToChild conversion is needed.
> > */
>
> That seems reasonable.
Cool!
> I think it's also worth adding the "ri_" prefix
> to the field names in those comments.
+1, so I created a patch incorporating your proposal, which I am attaching.
Thanks for the comment!
Best regards,
Etsuro Fujita
Attachment | Content-Type | Size |
---|---|---|
update-comments-in-ResultRelInfo-struct.patch | application/octet-stream | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2025-08-12 10:28:04 | Re: Obsolete comments in ResultRelInfo struct |
Previous Message | Fujii Masao | 2025-08-12 10:14:38 | Re: Excessive LOG messages from replication slot sync worker |