Re: Obsolete comments in ResultRelInfo struct

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Obsolete comments in ResultRelInfo struct
Date: 2025-08-11 17:02:59
Message-ID: CAEZATCU7BVjVeO7AQtijcnn0yfRttYeP-TNd6Y_L=KQfiF5jbA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 11 Aug 2025 at 12:25, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> /*
> * Other information needed by child result relations
> *
> * RootResultRelInfo gives the target relation mentioned in the query.
> * Used as the root for tuple routing and/or transition capture.
> *
> * PartitionTupleSlot is non-NULL if the relation is a partition to route
> * tuples into and RootToChild conversion is needed.
> */

That seems reasonable. I think it's also worth adding the "ri_" prefix
to the field names in those comments.

Regards,
Dean

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jingtang Zhang 2025-08-11 17:05:26 Re: Possible inaccurate description of wal_compression in docs
Previous Message Joe Conway 2025-08-11 16:53:05 Re: Generate GUC tables from .dat file