Re: Obsolete comments in ResultRelInfo struct

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Obsolete comments in ResultRelInfo struct
Date: 2025-08-17 10:50:51
Message-ID: CAPmGK16LJB7RLV_QBxN=XqR8HVXsp9gfDn_Y-Uw7Xo119Q4Qng@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 12, 2025 at 7:21 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Tue, Aug 12, 2025 at 2:03 AM Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> > On Mon, 11 Aug 2025 at 12:25, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > >
> > > /*
> > > * Other information needed by child result relations
> > > *
> > > * RootResultRelInfo gives the target relation mentioned in the query.
> > > * Used as the root for tuple routing and/or transition capture.
> > > *
> > > * PartitionTupleSlot is non-NULL if the relation is a partition to route
> > > * tuples into and RootToChild conversion is needed.
> > > */
> >
> > That seems reasonable.
>
> Cool!
>
> > I think it's also worth adding the "ri_" prefix
> > to the field names in those comments.
>
> +1, so I created a patch incorporating your proposal, which I am attaching.

Pushed and backpatched down to v14.

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-17 14:33:46 Re: VM corruption on standby
Previous Message Michael Paquier 2025-08-17 06:59:00 Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options