From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: the need to finish |
Date: | 2017-04-12 15:41:57 |
Message-ID: | CANP8+jJ19_iPup9do8PMvgKE-MnoGmiH+=u52F4TbiSMzomAyQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12 April 2017 at 16:26, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Erik Rijkers <er(at)xs4all(dot)nl> writes:
>> Logical replication emits logmessages like these:
>> DETAIL: 90 transactions need to finish.
>> DETAIL: 87 transactions need to finish.
>> DETAIL: 70 transactions need to finish.
>
>> Could we get rid of that 'need'? It strikes me as a bit off; something
>> that people would say but not a mechanical message by a computer. I
>> dislike it strongly.
>
>> I would prefer the line to be more terse:
>
>> DETAIL: 90 transactions to finish.
>
>> Am I the only one who is annoyed by this phrase?
>
> Our style guidelines say that detail messages should be complete
> sentences, so I don't like your proposal too much.
>
> Maybe "N transactions remain to finish." ?
waiting for N transactions to complete
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-04-12 15:43:27 | Re: error handling in RegisterBackgroundWorker |
Previous Message | Robert Haas | 2017-04-12 15:36:58 | Re: Partitioned tables and relfilenode |