| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: the need to finish |
| Date: | 2017-04-12 15:26:41 |
| Message-ID: | 6843.1492010801@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Erik Rijkers <er(at)xs4all(dot)nl> writes:
> Logical replication emits logmessages like these:
> DETAIL: 90 transactions need to finish.
> DETAIL: 87 transactions need to finish.
> DETAIL: 70 transactions need to finish.
> Could we get rid of that 'need'? It strikes me as a bit off; something
> that people would say but not a mechanical message by a computer. I
> dislike it strongly.
> I would prefer the line to be more terse:
> DETAIL: 90 transactions to finish.
> Am I the only one who is annoyed by this phrase?
Our style guidelines say that detail messages should be complete
sentences, so I don't like your proposal too much.
Maybe "N transactions remain to finish." ?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-04-12 15:31:09 | Re: GCC 7 warnings |
| Previous Message | Bruce Momjian | 2017-04-12 15:26:29 | Re: Some thoughts about SCRAM implementation |