Re: PostgreSQL 15 minor fixes in protocol.sgml

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ekaterina Kiryanova <e(dot)kiryanova(at)postgrespro(dot)ru>, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: PostgreSQL 15 minor fixes in protocol.sgml
Date: 2022-08-03 05:26:25
Message-ID: CAHut+Ps8TLKFL0P4ghgERdTcDeB4y61zWm128524h88BhnYmfA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Wed, Aug 3, 2022 at 1:58 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Aug 2, 2022 at 4:28 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Mon, Aug 01, 2022 at 11:00:20PM +0300, Ekaterina Kiryanova wrote:
> >
> > > Another point worth mentioning is that only this file contains the phrase
> > > "two-phase transaction". I believe that "two-phase commit transaction" or
> > > "transaction prepared for two-phase commit" depending on the situation would
> > > be better wording.
> >
> > "Prepare for two-phase commit" may be clearer?
> >
>
> I think we can use just "Prepared transaction" instead. So, the
> message "The user defined GID of the two-phase transaction." can be
> changed to "The user defined GID of the prepared transaction.".
> Similarly, the message "Identifies the message as a two-phase prepared
> transaction message." could be changed to: "Identifies the message as
> a prepared transaction message."
>
> > > And finally, could you please clarify this part?
> > > -- The end LSN of the prepare transaction.
> > > Is it a typo of "prepared transaction"?
>
> I think in this case it should be a "prepared transaction".
>
>
> Thanks for the report and Thanks Michael for including me. I am just
> redirecting it to -hackers so that others involved in this feature
> also can share their views.
>

PSA a patch to modify the descriptions as suggested by Amit.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v1-0001-modify-protocol-message-descriptions-for-2PC.patch application/octet-stream 5.3 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Alvaro Herrera 2022-08-03 10:53:15 Re: PostgreSQL 15 minor fixes in protocol.sgml
Previous Message Amit Kapila 2022-08-03 03:57:58 Re: PostgreSQL 15 minor fixes in protocol.sgml

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2022-08-03 05:36:20 Re: optimize lookups in snapshot [sub]xip arrays
Previous Message Etsuro Fujita 2022-08-03 05:24:48 Re: postgres_fdw: batch inserts vs. before row triggers