Re: PostgreSQL 15 minor fixes in protocol.sgml

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Ekaterina Kiryanova <e(dot)kiryanova(at)postgrespro(dot)ru>, pgsql-docs(at)lists(dot)postgresql(dot)org, Ajin Cherian <itsajin(at)gmail(dot)com>
Subject: Re: PostgreSQL 15 minor fixes in protocol.sgml
Date: 2022-08-04 03:04:47
Message-ID: CAA4eK1LHSDb3KVRZZnYeBF0-SodMKYP=V+2VmrVBvRNK=ej1Tw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Wed, Aug 3, 2022 at 10:56 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> PSA a patch to modify the descriptions as suggested by Amit.
>

*
<para>
- The end LSN of the commit prepared transaction.
+ The end LSN of the commit of the prepared transaction.
...
...
- Identifies the message as the commit of a two-phase
transaction message.
+ Identifies the message as the commit of a prepared
transaction message.

In the above messages, we can even directly say "commit prepared
transaction" but as you have written appears clear to me.

*
For timestamp, related messages, we have three different messages:
Commit timestamp of the transaction. The value is in number of
microseconds since PostgreSQL epoch (2000-01-01).
Prepare timestamp of the transaction. The value is in number of
microseconds since PostgreSQL epoch (2000-01-01).
Rollback timestamp of the transaction. The value is in number of
microseconds since PostgreSQL epoch (2000-01-01).

We can improve by saying "Timestamp of prepared transaction" for the
second one but it will make it bit inconsistent with others, so not
sure if changing it makes sense or if there is a better way to change
all the three messages.

Thoughts?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Amit Kapila 2022-08-04 03:06:51 Re: PostgreSQL 15 minor fixes in protocol.sgml
Previous Message PG Doc comments form 2022-08-03 13:29:58 The sample FDW table: pglog not work in https://www.postgresql.org/docs/14/file-fdw.html

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-08-04 03:06:51 Re: PostgreSQL 15 minor fixes in protocol.sgml
Previous Message Thomas Munro 2022-08-04 02:54:41 Re: standby recovery fails (tablespace related) (tentative patch and discussion)