Re: Relax transactional restrictions on ALTER ENUM ... ADD TYPE (redux)

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Relax transactional restrictions on ALTER ENUM ... ADD TYPE (redux)
Date: 2018-10-06 00:35:44
Message-ID: CAEepm=0cQ4wdhzTyH6nefCg1wApcPtLu+bNrXFC6JY_zjZcnew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Sat, Oct 6, 2018 at 2:31 AM Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
> >> On Wed, Oct 3, 2018 at 2:24 PM Thomas Munro
> >> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> >>> Over the thread for bug #14825 I posted some draft code to show one
> >>> way to save/restore the enum blacklist for parallel workers. Here's a
> >>> better version, and a new thread. 0001 is the code by Andrew Dustan
> >>> and Tom Lane that was reverted in 93a1af0b, unchanged by me except for
> >>> resolving trivial conflicts on current master. 0002 fixes the failure
> >>> seen with make installcheck when postgresql.conf says
> >>> force_parallel_mode = regress.
>
> Many thanks for doing this. Your solution seems simpler and cleaner that
> what was previously proposed.
>
> I have tested it, and confirm that without your 0002 patch there is an
> error with force_parallel_mode=regress and with 0002 that error goes away.

Thanks. Here is a version squashed into one commit, with a decent
commit message and a small improvement: the code to create the hash
table is moved into a static function, to avoid repetition. I will
push this to master early next week, unless there is more feedback or
one of you would prefer to do that.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
0001-Relax-transactional-restrictions-on-ALTER-TYPE-.--v3.patch application/octet-stream 26.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-10-06 01:10:09 Re: Segfault when creating partition with a primary key and sql_drop trigger exists
Previous Message Michael Paquier 2018-10-06 00:00:40 Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1