Re: Segfault when creating partition with a primary key and sql_drop trigger exists

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marco Slot <marco(at)citusdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Onder Kalaci <onder(at)citusdata(dot)com>
Subject: Re: Segfault when creating partition with a primary key and sql_drop trigger exists
Date: 2018-10-06 01:10:09
Message-ID: 20181006011009.sy7yeuvgvgmpf3bq@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Oct-06, Michael Paquier wrote:

> On Fri, Oct 05, 2018 at 04:04:02PM -0400, Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> >> On 2018-Oct-04, Tom Lane wrote:
> >>> Not sure about that. Alvaro seems to think there's a generic problem
> >>> in event trigger processing, which if true, was likely there pre-v11.
> >
> >> After sleeping on this, I think that a better answer is to fix the crash
> >> per Michael's proposed patch, and fix the rest of the deparse problem
> >> later.
> >
> > Well, let's push it sooner not later, so we can get buildfarm coverage
> > before RC1.
>
> I have to admit that I am not confident enough to commit this patch
> myself yet as I would need to spend a couple of extra hours on it and
> looking at the event triggers generated for other event types, and there
> is a three-day weekend waiting ahead in Japan. Could any of you take
> care of it?

Sure, I'll look into it tomorrow.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-10-06 02:27:59 Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1
Previous Message Thomas Munro 2018-10-06 00:35:44 Re: Relax transactional restrictions on ALTER ENUM ... ADD TYPE (redux)