Re: Relax transactional restrictions on ALTER ENUM ... ADD TYPE (redux)

On 10/05/2018 08:35 PM, Thomas Munro wrote:
> On Sat, Oct 6, 2018 at 2:31 AM Andrew Dunstan
> <andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>>>> On Wed, Oct 3, 2018 at 2:24 PM Thomas Munro
>>>> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>>>>> Over the thread for bug #14825 I posted some draft code to show one
>>>>> way to save/restore the enum blacklist for parallel workers. Here's a
>>>>> better version, and a new thread. 0001 is the code by Andrew Dustan
>>>>> and Tom Lane that was reverted in 93a1af0b, unchanged by me except for
>>>>> resolving trivial conflicts on current master. 0002 fixes the failure
>>>>> seen with make installcheck when postgresql.conf says
>>>>> force_parallel_mode = regress.
>> Many thanks for doing this. Your solution seems simpler and cleaner that
>> what was previously proposed.
>>
>> I have tested it, and confirm that without your 0002 patch there is an
>> error with force_parallel_mode=regress and with 0002 that error goes away.
> Thanks. Here is a version squashed into one commit, with a decent
> commit message and a small improvement: the code to create the hash
> table is moved into a static function, to avoid repetition. I will
> push this to master early next week, unless there is more feedback or
> one of you would prefer to do that.
>

Go for it.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services