From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Subject: | Re: max_sync_workers_per_subscription is missing in postgresql.conf |
Date: | 2017-04-10 12:39:52 |
Message-ID: | CAD21AoCF6Hn-bGOJe6=gR+EVe-_kfvxVmmBZrKmkV+pgvrjEZw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Apr 10, 2017 at 9:32 PM, Petr Jelinek
<petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
> On 10/04/17 07:16, Masahiko Sawada wrote:
>> Hi all,
>>
>> Attached a patch for $subject.
>>
>> I added this parameter into "Asynchronous Behavior" section of
>> "RESOURCE" section. But GUC parameter for subscriber now is written in
>> this section, in spite of there is "REPLICATION" section. I think that
>> we can coordinate these parameters to not confuse user. For example in
>> documentation, these parameters are described in "19.6.4. Subscribers"
>> section of "19.6. Replication" section. Thought?
>>
>
> Good catch, but it's actually taken from max_logical_replication_workers
> so the patch should look more like attached IMHO.
>
Thank you for the patch. The patch looks good to me.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-04-10 12:40:21 | Re: logical replication and SIGHUP |
Previous Message | Petr Jelinek | 2017-04-10 12:32:55 | Re: max_sync_workers_per_subscription is missing in postgresql.conf |