| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, peter(dot)eisentraut(at)2ndquadrant(dot)com, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical replication and SIGHUP |
| Date: | 2017-04-10 12:40:21 |
| Message-ID: | 21464.1491828021@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
> Looks good to me. Just as a note, we'll have to handle this newly
> supported config rereads in the async commit patch where we override
> synchronous_commit GUC, but the config reread will change it back.
Umm ... you're doing what?
There are mechanisms for making local changes to a GUC. Just stomping
on the variable is not an approved way to do it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-04-10 12:46:29 | Re: logical replication and SIGHUP |
| Previous Message | Masahiko Sawada | 2017-04-10 12:39:52 | Re: max_sync_workers_per_subscription is missing in postgresql.conf |