Re: max_sync_workers_per_subscription is missing in postgresql.conf

From: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: max_sync_workers_per_subscription is missing in postgresql.conf
Date: 2017-04-10 12:32:55
Message-ID: f9c00734-b10a-0e76-84be-251af62083da@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/04/17 07:16, Masahiko Sawada wrote:
> Hi all,
>
> Attached a patch for $subject.
>
> I added this parameter into "Asynchronous Behavior" section of
> "RESOURCE" section. But GUC parameter for subscriber now is written in
> this section, in spite of there is "REPLICATION" section. I think that
> we can coordinate these parameters to not confuse user. For example in
> documentation, these parameters are described in "19.6.4. Subscribers"
> section of "19.6. Replication" section. Thought?
>

Good catch, but it's actually taken from max_logical_replication_workers
so the patch should look more like attached IMHO.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
Add_max_sync_workers_per_subscription_into_postgresql_conf.patch application/x-patch 699 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-04-10 12:39:52 Re: max_sync_workers_per_subscription is missing in postgresql.conf
Previous Message Michael Paquier 2017-04-10 12:30:25 Re: Compiler warning in costsize.c