From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | reid(dot)thompson(at)crunchydata(dot)com |
Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Subject: | Re: Remove unused fields in ReorderBufferTupleBuf |
Date: | 2024-01-26 04:51:39 |
Message-ID: | CAD21AoAyLg0O3jtRgmw5i3_PdGKLOwTxjFvav0zwcqF0My43fA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jan 26, 2024 at 1:24 PM <reid(dot)thompson(at)crunchydata(dot)com> wrote:
>
> On Thu, 2024-01-25 at 16:11 -0500, reid(dot)thompson(at)crunchydata(dot)com wrote:
> >
> > I walked through v6 and didn't note any issues.
Thank you for reviewing the patch!
> >
> > I do want to ask, the patch alters ReorderBufferReturnTupleBuf() and
> > drops the unused parameter ReorderBuffer *rb. It seems that
> > ReorderBufferFreeSnap(), ReorderBufferReturnRelids(),
> > ReorderBufferImmediateInvalidation(), and ReorderBufferRestoreCleanup()
> > also pass ReorderBuffer *rb but do not use it. Would it be beneficial
> > to implement a separate patch to remove this parameter from these
> > functions also?
> >
> >
>
> It also appears that ReorderBufferSerializeChange() has 5 instances
> where it increments the local variables "data" but then they're never
> read.
> Lines 3806, 3836, 3854, 3889, 3910
>
> I can create patch and post it to this thread or a new one if deemed
> worthwhile.
I'm not sure these changes are really beneficial. They contribute to
improving neither readability and performance IMO.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2024-01-26 04:59:09 | Re: Small fix on COPY ON_ERROR document |
Previous Message | reid.thompson | 2024-01-26 04:23:51 | Re: Remove unused fields in ReorderBufferTupleBuf |