| From: | reid(dot)thompson(at)crunchydata(dot)com |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Remove unused fields in ReorderBufferTupleBuf |
| Date: | 2024-01-26 04:23:51 |
| Message-ID: | db1f1074edca415556d873cf2b07fe2c0d6ecaae.camel@crunchydata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2024-01-25 at 16:11 -0500, reid(dot)thompson(at)crunchydata(dot)com wrote:
>
> I walked through v6 and didn't note any issues.
>
> I do want to ask, the patch alters ReorderBufferReturnTupleBuf() and
> drops the unused parameter ReorderBuffer *rb. It seems that
> ReorderBufferFreeSnap(), ReorderBufferReturnRelids(),
> ReorderBufferImmediateInvalidation(), and ReorderBufferRestoreCleanup()
> also pass ReorderBuffer *rb but do not use it. Would it be beneficial
> to implement a separate patch to remove this parameter from these
> functions also?
>
> Thanks,
> Reid
>
It also appears that ReorderBufferSerializeChange() has 5 instances
where it increments the local variables "data" but then they're never
read.
Lines 3806, 3836, 3854, 3889, 3910
I can create patch and post it to this thread or a new one if deemed
worthwhile.
Thanks,
Reid
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-01-26 04:51:39 | Re: Remove unused fields in ReorderBufferTupleBuf |
| Previous Message | David Rowley | 2024-01-26 04:18:17 | Re: A performance issue with Memoize |