Re: Remove unused fields in ReorderBufferTupleBuf

From: reid(dot)thompson(at)crunchydata(dot)com
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: Remove unused fields in ReorderBufferTupleBuf
Date: 2024-01-26 14:54:12
Message-ID: 70d86583012475ea91192e139c3022c8d7541bad.camel@crunchydata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2024-01-26 at 13:51 +0900, Masahiko Sawada wrote:
> On Fri, Jan 26, 2024 at 1:24 PM <reid(dot)thompson(at)crunchydata(dot)com> wrote:
> >
> > On Thu, 2024-01-25 at 16:11 -0500, reid(dot)thompson(at)crunchydata(dot)com wrote:
> > >
> > > I walked through v6 and didn't note any issues.
>
> Thank you for reviewing the patch!
>
Happy to.
>
> I'm not sure these changes are really beneficial. They contribute to
> improving neither readability and performance IMO.
>
> Regards,
>
I thought that may be the case, but wanted to ask to be sure. Thank you
for the followup.

Reid

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2024-01-26 14:58:34 Re: Transaction timeout
Previous Message vignesh C 2024-01-26 14:53:20 Re: Lockless queue of waiters in LWLock