| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Small fix on COPY ON_ERROR document |
| Date: | 2024-01-26 04:59:09 |
| Message-ID: | CAD21AoBAAxPdEdDJTwJRQbiQ-+xhfPDcfcPPSddpzTsO9xMLzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 26, 2024 at 11:28 AM Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> Hi,
>
> I found that the documentation of COPY ON_ERROR said
> COPY stops operation at the first error when
> "ON_ERROR is not specified.", but it also stop when
> ON_ERROR is specified to the default value, "stop".
>
> I attached a very small patch to fix this just for
> making the description more accurate.
Thank you for the patch!
+1 to fix it.
- <literal>ON_ERROR</literal> is not specified. This
- should not lead to problems in the event of a <command>COPY
+ <literal>ON_ERROR</literal> is not specified or <literal>stop</literal>.
+ This should not lead to problems in the event of a <command>COPY
How about the followings for consistency with the description of the
ON_ERROR option?
COPY stops operation at the first error if the stop value is specified
to the ON_ERROR option. This should not lead to ...
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-01-26 05:38:53 | Re: A performance issue with Memoize |
| Previous Message | Masahiko Sawada | 2024-01-26 04:51:39 | Re: Remove unused fields in ReorderBufferTupleBuf |