Re: typedef struct WindowClause misleading comments

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: typedef struct WindowClause misleading comments
Date: 2026-06-09 02:15:01
Message-ID: CAApHDvrB83=+aG6JAXyhOtz4x_U3VAjOyBtJ=TGp=PQQDic5eA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 9 Jun 2026 at 13:56, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> Query jumbling considers the ORDER BY clause; therefore, the comment
> below is inaccurate.
>
> /
> * The information relevant for the query jumbling is the partition clause
> * type and its bounds.
> */

I think the comment should be deleted. It's pretty obvious which
fields are used by looking at the pg_node_attr(query_jumble_ignore)
attributes.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-06-09 02:19:25 Re: Fix tuple deformation with virtual generated NOT NULL columns
Previous Message jian he 2026-06-09 01:55:47 typedef struct WindowClause misleading comments