Re: typedef struct WindowClause misleading comments

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: typedef struct WindowClause misleading comments
Date: 2026-06-09 06:11:57
Message-ID: CACJufxHD2rrEgdp-6oMsJeR0TqRWLb_oV3uUWscmsz1fHrqS_w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 9, 2026 at 10:15 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Tue, 9 Jun 2026 at 13:56, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > Query jumbling considers the ORDER BY clause; therefore, the comment
> > below is inaccurate.
> >
> > /
> > * The information relevant for the query jumbling is the partition clause
> > * type and its bounds.
> > */
>
> I think the comment should be deleted. It's pretty obvious which
> fields are used by looking at the pg_node_attr(query_jumble_ignore)
> attributes.
>

I agree.
Let's delete it.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-06-09 06:13:54 Re: t/035_standby_logical_decoding.pl might fail on attempt to read wrong timeline
Previous Message Bertrand Drouvot 2026-06-09 06:03:28 Re: t/035_standby_logical_decoding.pl might fail on attempt to read wrong timeline