typedef struct WindowClause misleading comments

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: typedef struct WindowClause misleading comments
Date: 2026-06-09 01:55:47
Message-ID: CACJufxEWeP2SLVMsbFNynd0pQnwbxh6U-v1nq5ccf9mSvBZntw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi.

Query jumbling considers the ORDER BY clause; therefore, the comment
below is inaccurate.

/
* The information relevant for the query jumbling is the partition clause
* type and its bounds.
*/
typedef struct WindowClause
{
NodeTag type;
/* window name (NULL in an OVER clause) */
char *name pg_node_attr(query_jumble_ignore);
/* referenced window name, if any */
char *refname pg_node_attr(query_jumble_ignore);
List *partitionClause; /* PARTITION BY list */
/* ORDER BY list */
List *orderClause;
int frameOptions; /* frame_clause options, see WindowDef */
Node *startOffset; /* expression for starting bound, if any */
Node *endOffset; /* expression for ending bound, if any */
.....
}

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-06-09 02:15:01 Re: typedef struct WindowClause misleading comments
Previous Message Chao Li 2026-06-09 00:38:02 Re: pg_createsubscriber: allow duplicate publication names