| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: typedef struct WindowClause misleading comments |
| Date: | 2026-06-09 16:54:49 |
| Message-ID: | 892312.1781024089@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Tue, 9 Jun 2026 at 13:56, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>> Query jumbling considers the ORDER BY clause; therefore, the comment
>> below is inaccurate.
>>
>> /
>> * The information relevant for the query jumbling is the partition clause
>> * type and its bounds.
>> */
> I think the comment should be deleted. It's pretty obvious which
> fields are used by looking at the pg_node_attr(query_jumble_ignore)
> attributes.
+1. There are also other comments about query jumbling in nodes/*.h that
seem pretty information-free now. They might have been helpful before
we invented query_jumble_ignore and related annotations, but now they
seem just duplicative.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-06-09 17:03:49 | Re: Fix missing semicolon in pl_gram.y for option_value rule |
| Previous Message | Joao Foltran | 2026-06-09 16:24:01 | Re: [BUG] [PATCH] Allow physical replication slots to recover from archive after invalidation |